Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/36#discussion_r45612666
  
    --- Diff: include/qpid/dispatch/router_core.h ---
    @@ -322,5 +322,5 @@ void qdr_query_free(qdr_query_t *query);
     
     typedef void (*qdr_manage_response_t) (void *context, const 
qd_amqp_error_t *status, bool more);
     void qdr_manage_handler(qdr_core_t *core, qdr_manage_response_t 
response_handler);
    -
    +bool qdr_is_set_manage_handler(qdr_core_t *core);
    --- End diff --
    
    I don't think this is needed.  The "outer" agent should register its 
callbacks once at initialization time.  It is not safe to register new handlers 
for each request that comes in and it's not necessary to repeatedly register 
the same handler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to