[
https://issues.apache.org/jira/browse/QPID-6884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15024320#comment-15024320
]
Lorenz Quack commented on QPID-6884:
------------------------------------
Steps to reproduce:
# start broker
# click add Broker Logger
# enter arbitrary name
# select "File" as the Type
# enter a relative path without parent as the filename, e.g. "foo"
# click add
result: "500 - Invalid character"
Broker log:
{noformat}
2015-11-24 11:42:40,075 DEBUG [HttpManagement-HTTP-135]
(o.a.q.s.m.p.f.LoggingFilter) - REQUEST user='[/127.0.0.1:59173, admin]'
method='POST' url='http://localhost:8080/api/latest/brokerlogger'
2015-11-24 11:42:40,085 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Performing Task['create child' on 'BrokerAdapter
[id=3cf073fb-da56-4c09-bbeb-fa6bb1d8286e, name=Broker]' with arguments
'childClass=BrokerLogger, name=baz, type=File']
2015-11-24 11:42:40,103 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Performing Task['create' on 'BrokerFileLoggerImpl
[id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d, name=baz]']
2015-11-24 11:42:40,105 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Performing Task['set desired state' on 'BrokerFileLoggerImpl
[id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d, name=baz]' with arguments 'DELETED']
2015-11-24 11:42:40,116 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Performing Task['close' on 'BrokerFileLoggerImpl
[id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d, name=baz]']
2015-11-24 11:42:40,117 DEBUG [Broker-Config]
(o.a.q.s.m.AbstractConfiguredObject) - Closing BrokerFileLoggerImpl : baz
2015-11-24 11:42:40,119 DEBUG [Broker-Config]
(o.a.q.s.m.AbstractConfiguredObject) - All children closed BrokerFileLoggerImpl
: baz
2015-11-24 11:42:40,121 DEBUG [Broker-Config]
(o.a.q.s.m.AbstractConfiguredObject) - Closed BrokerFileLoggerImpl : baz
2015-11-24 11:42:40,121 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Task['close' on 'BrokerFileLoggerImpl [id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d,
name=baz]'] performed successfully with result: null
2015-11-24 11:42:40,139 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Task['set desired state' on 'BrokerFileLoggerImpl
[id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d, name=baz]' with arguments 'DELETED']
performed successfully with result: null
2015-11-24 11:42:40,139 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Task['create' on 'BrokerFileLoggerImpl
[id=529fcbfb-f405-4ff4-b1ea-ccf6d666fc2d, name=baz]'] performed successfully
with result: null
2015-11-24 11:42:40,141 DEBUG [Broker-Config] (o.a.q.s.c.u.TaskExecutorImpl) -
Task['create child' on 'BrokerAdapter [id=3cf073fb-da56-4c09-bbeb-fa6bb1d8286e,
name=Broker]' with arguments 'childClass=BrokerLogger, name=baz, type=File']
performed successfully with result: null
2015-11-24 11:42:40,141 DEBUG [HttpManagement-HTTP-135]
(o.a.q.s.m.p.f.LoggingFilter) - RESPONSE user='[/127.0.0.1:59173, admin]'
method='POST' url='http://localhost:8080/api/latest/brokerlogger' status='200'
2015-11-24 11:42:40,148 ERROR [HttpManagement-HTTP-135]
(o.a.q.s.m.p.f.ExceptionHandlingFilter) - Unexpected exception in servlet
'/api/latest/brokerlogger':
java.lang.NullPointerException: null
at
org.apache.qpid.server.logging.AppenderUtils.validateLogFilePermissions(AppenderUtils.java:100)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.AppenderUtils.configureRollingFileAppender(AppenderUtils.java:50)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.BrokerFileLoggerImpl.createAppenderInstance(BrokerFileLoggerImpl.java:213)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.AbstractLogger.postResolveChildren(AbstractLogger.java:69)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.BrokerFileLoggerImpl.postResolveChildren(BrokerFileLoggerImpl.java:92)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.doResolution(AbstractConfiguredObject.java:1004)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:742)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:718)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:520)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:513)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:270)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:154)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:142)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:512)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:717)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:76)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:125)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.adapter.BrokerAdapter.addChildAsync(BrokerAdapter.java:618)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$18.execute(AbstractConfiguredObject.java:1851)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$18.execute(AbstractConfiguredObject.java:1846)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:520)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:513)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:270)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:342)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at java.security.AccessController.doPrivileged(Native Method)
~[na:1.7.0_79]
at javax.security.auth.Subject.doAs(Subject.java:356) ~[na:1.7.0_79]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:335)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
~[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
~[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
~[na:1.7.0_79]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_79]
2015-11-24 11:42:40,149 WARN [HttpManagement-HTTP-135]
(o.e.j.s.ServletHandler) - /api/latest/brokerlogger
java.lang.NullPointerException: null
at
org.apache.qpid.server.logging.AppenderUtils.validateLogFilePermissions(AppenderUtils.java:100)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.AppenderUtils.configureRollingFileAppender(AppenderUtils.java:50)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.BrokerFileLoggerImpl.createAppenderInstance(BrokerFileLoggerImpl.java:213)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.AbstractLogger.postResolveChildren(AbstractLogger.java:69)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.logging.BrokerFileLoggerImpl.postResolveChildren(BrokerFileLoggerImpl.java:92)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.doResolution(AbstractConfiguredObject.java:1004)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:742)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$6.execute(AbstractConfiguredObject.java:718)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:520)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:513)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:270)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submitWrappedTask(TaskExecutorImpl.java:154)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl.submit(TaskExecutorImpl.java:142)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.doOnConfigThread(AbstractConfiguredObject.java:512)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject.createAsync(AbstractConfiguredObject.java:717)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObjectTypeFactory.createAsync(AbstractConfiguredObjectTypeFactory.java:76)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.ConfiguredObjectFactoryImpl.createAsync(ConfiguredObjectFactoryImpl.java:125)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.adapter.BrokerAdapter.addChildAsync(BrokerAdapter.java:618)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$18.execute(AbstractConfiguredObject.java:1851)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$18.execute(AbstractConfiguredObject.java:1846)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:520)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.model.AbstractConfiguredObject$2.execute(AbstractConfiguredObject.java:513)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$TaskLoggingWrapper.execute(TaskExecutorImpl.java:270)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper$1.run(TaskExecutorImpl.java:342)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at java.security.AccessController.doPrivileged(Native Method)
~[na:1.7.0_79]
at javax.security.auth.Subject.doAs(Subject.java:356) ~[na:1.7.0_79]
at
org.apache.qpid.server.configuration.updater.TaskExecutorImpl$CallableWrapper.call(TaskExecutorImpl.java:335)
~[qpid-broker-core-6.0.0-SNAPSHOT.jar:6.0.0-SNAPSHOT]
at java.util.concurrent.FutureTask.run(FutureTask.java:262)
~[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
~[na:1.7.0_79]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
~[na:1.7.0_79]
at java.lang.Thread.run(Thread.java:745) [na:1.7.0_79]
{noformat}
> [Java Broker] Adding a BrokerLogger with a relative path without a slash fails
> ------------------------------------------------------------------------------
>
> Key: QPID-6884
> URL: https://issues.apache.org/jira/browse/QPID-6884
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Environment: Internet Explorer 11
> Reporter: Lorenz Quack
>
> When adding/editing a BrokerLogger setting File Name to "foo" in add/edit
> dialogue results in 500 - Illegal character
> The cause is a NullPointerException in
> AppenderUtils#validateLogFilePermissions when the filename does not have a
> parent.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
