[
https://issues.apache.org/jira/browse/QPID-6869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026696#comment-15026696
]
Lorenz Quack edited comment on QPID-6869 at 11/25/15 2:13 PM:
--------------------------------------------------------------
Three more things:
In {{TCPTunnler}}:
* In the constructor the first argument is a port not the host and there is a
typo in {{remotetHost}}
* Is there a reason the nested classes are not private?
In {{AbruptClientDisconnectTest}}
* You did not address restoring the interrupt flag in the InterruptException
handler. I think calling {{_thread.interrupt()}} is good but I think
additionally you should call {{Thread.currentThread().interrupt()}}
The rest of the changes look good!
EDIT: moved the comment about nested classes to the correct place
was (Author: lorenz.quack):
Three more things:
In {{TCPTunnler}}:
* In the constructor the first argument is a port not the host and there is a
typo in {{remotetHost}}
In {{AbruptClientDisconnectTest}}
* Is there a reason the nested classes are not private?
* You did not address restoring the interrupt flag in the InterruptException
handler. I think calling {{_thread.interrupt()}} is good but I think
additionally you should call {{Thread.currentThread().interrupt()}}
The rest of the changes look good!
> Add system test that ensures messaging is reliable when the client is
> disconnected abruptly or killed
> -----------------------------------------------------------------------------------------------------
>
> Key: QPID-6869
> URL: https://issues.apache.org/jira/browse/QPID-6869
> Project: Qpid
> Issue Type: Test
> Components: Java Tests
> Reporter: Alex Rudyy
> Assignee: Lorenz Quack
> Fix For: qpid-java-6.0
>
>
> Add system test that tests messaging functionality on abrupt java client
> disconnect (kill) whilst it is sending and receiving messages.
> Usable from both the IDE and Maven.
> Probably configured from the command line (broker, queue etc)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
