Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/38#discussion_r46554871
--- Diff: python/qpid_dispatch/management/qdrouter.json ---
@@ -633,7 +633,13 @@
"default": "both",
"description": "['in', 'out', 'both', 'no'] in: Strip
the dispatch router specific annotations only on ingress; out: Strip the
dispatch router specific annotations only on egress; both: Strip the dispatch
router specific annotations on both ingress and egress; no - do not strip
dispatch router specific annotations",
"create": true
- }
+ },
+ "protocolFamily": {
--- End diff --
Rather than duplicate this entry for both listener and connector, you could
put this in the "addrPort" annotation. Like addr and port, protocolFamily is
common to both entity types.
You have a default of IPv4 in the connector. That is inconsistent with the
document string.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
