[ 
https://issues.apache.org/jira/browse/QPID-6953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062186#comment-15062186
 ] 

Alex Rudyy edited comment on QPID-6953 at 12/17/15 3:37 PM:
------------------------------------------------------------

Rob,
Commit [r1720183|https://svn.apache.org/r1720183] broke message encryption on 
0-10 path. 

MessageEncryptionTest is failing constantly on 0-10 profile. 0-9 profile is Ok
{noformat}
Running org.apache.qpid.systest.messageencryption.MessageEncryptionTest
Tests run: 6, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 8.888 sec <<< 
FAILURE! - in org.apache.qpid.systest.messageencryption.MessageEncryptionTest
testEncryptionFromBURLAddress(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.336 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionFromBURLAddress(MessageEncryptionTest.java:169)

testEncryptionUsingMessageHeader(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.273 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionUsingMessageHeader(MessageEncryptionTest.java:89)

testBrokerAsTrustStoreProvider(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.303 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testBrokerAsTrustStoreProvider(MessageEncryptionTest.java:211)

testEncryptionFromADDRAddress(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.298 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionFromADDRAddress(MessageEncryptionTest.java:127)

{noformat}

NPE is reported in test logs
{noformat}
2015-12-17 15:24:17,136         ERROR [Dispatcher-1-Conn-10] 
o.a.q.c.BasicMessageConsumer Caught exception (dump follows) - ignoring...
java.lang.NullPointerException: null
        at 
org.apache.qpid.client.message.AMQMessageDelegate_0_10.<init>(AMQMessageDelegate_0_10.java:120)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.AMQMessageDelegate_0_10.<init>(AMQMessageDelegate_0_10.java:106)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.Encrypted010MessageFactory.createMessage(Encrypted010MessageFactory.java:160)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.AbstractJMSMessageFactory.create010MessageWithBody(AbstractJMSMessageFactory.java:177)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.AbstractJMSMessageFactory.createMessage(AbstractJMSMessageFactory.java:198)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.MessageFactoryRegistry.createMessage(MessageFactoryRegistry.java:160)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.BasicMessageConsumer_0_10.createJMSMessageFromUnprocessedMessage(BasicMessageConsumer_0_10.java:212)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.BasicMessageConsumer_0_10.createJMSMessageFromUnprocessedMessage(BasicMessageConsumer_0_10.java:55)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.BasicMessageConsumer.notifyMessage(BasicMessageConsumer.java:722)
 ~[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.BasicMessageConsumer_0_10.notifyMessage(BasicMessageConsumer_0_10.java:189)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.BasicMessageConsumer_0_10.notifyMessage(BasicMessageConsumer_0_10.java:55)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.AMQSession$Dispatcher.notifyConsumer(AMQSession.java:3633)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.AMQSession$Dispatcher.dispatchMessage(AMQSession.java:3565)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.AMQSession$Dispatcher.access$1000(AMQSession.java:3326) 
[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at org.apache.qpid.client.AMQSession.dispatch(AMQSession.java:3319) 
[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.message.UnprocessedMessage.dispatch(UnprocessedMessage.java:54)
 [qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
        at 
org.apache.qpid.client.AMQSession$Dispatcher.run(AMQSession.java:3475) 
[qpid-client-6.1.0-SNAPSHOT.jar:6.1.0-SNAPSHOT]
{noformat}


was (Author: alex.rufous):
Rob,
Commit [r1720183|https://svn.apache.org/r1720183] broke message encryption on 
0-10 path. 

MessageEncryptionTest is failing constantly on 0-10 profile. 0-9 profile is Ok
{noformat}
Running org.apache.qpid.systest.messageencryption.MessageEncryptionTest
Tests run: 6, Failures: 4, Errors: 0, Skipped: 0, Time elapsed: 8.888 sec <<< 
FAILURE! - in org.apache.qpid.systest.messageencryption.MessageEncryptionTest
testEncryptionFromBURLAddress(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.336 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionFromBURLAddress(MessageEncryptionTest.java:169)

testEncryptionUsingMessageHeader(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.273 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionUsingMessageHeader(MessageEncryptionTest.java:89)

testBrokerAsTrustStoreProvider(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.303 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testBrokerAsTrustStoreProvider(MessageEncryptionTest.java:211)

testEncryptionFromADDRAddress(org.apache.qpid.systest.messageencryption.MessageEncryptionTest)
  Time elapsed: 1.298 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:55)
        at junit.framework.Assert.assertTrue(Assert.java:22)
        at junit.framework.Assert.assertNotNull(Assert.java:256)
        at junit.framework.Assert.assertNotNull(Assert.java:248)
        at junit.framework.TestCase.assertNotNull(TestCase.java:417)
        at 
org.apache.qpid.systest.messageencryption.MessageEncryptionTest.testEncryptionFromADDRAddress(MessageEncryptionTest.java:127)

{noformat}

> [Java Broker] Refactor AMQP 0-8/9/9-1 implementation to always use 
> QpidByteBuffer for encoding output
> -----------------------------------------------------------------------------------------------------
>
>                 Key: QPID-6953
>                 URL: https://issues.apache.org/jira/browse/QPID-6953
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: qpid-java-6.1
>
>
> Currently many parts of the AMQP 0-8/9/9-1 codec offer two methods for 
> encoding, one which uses a "DataOutput" object, and one which uses a 
> QpidByteBuffer or ByteBufferSender.  Examples of the former should be 
> removed, and the latter used exclusively.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to