[ 
https://issues.apache.org/jira/browse/QPID-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132179#comment-15132179
 ] 

Rob Godfrey commented on QPID-7035:
-----------------------------------

* {{PlainPasswordFilePrincipalDatabase}} : Why not use the context value rather 
than the hardcoded default for the iteration count?
* 
{{AbstractScramAuthenticationManager.updateStoredPasswordFormatIfNecessary()}} 
: Given we are upgrading shouldn't the iteration count added to the file always 
be 4096, not the current default? (also no need to use {{DatatypeConverter}} to 
print the int)
* {{AbstractScramAuthenticationManager.createStoredPassword(final String 
password)}} : again {{DatatypeConverter.printInt(iterationCount)}} can be 
replaced with iterationCount
* {{AbstractScramAuthenticationManager.getSaltAndPasswordKeys(final String 
username)}} : replace 
{{DatatypeConverter.parseInt(passwordFields\[PasswordField.ITERATION_COUNT.ordinal()\])}}
 with {{Integer.parseInt()}}  ({{DatatypeConverter}} is intended for use in XML 
bindings, but it's the only class in the core JDK libraries that does base64 
encoding/parsing)
* {{PlainAuthenticationProvider}} / {{SimpleAuthenticationManager}} : Again why 
not use the context value rather than the hardcoded default for the iteration 
count?
* {{ScramSaslServer}} : Again, no need to use {{DatatypeConverter}}


> [Java Broker] SCRAM implementation should make iteration count configurable
> ---------------------------------------------------------------------------
>
>                 Key: QPID-7035
>                 URL: https://issues.apache.org/jira/browse/QPID-7035
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: qpid-java-6.0
>            Reporter: Lorenz Quack
>            Assignee: Rob Godfrey
>
> SCRAM has a iteration count parameter which is used in the PBKDF.
> In the current implementation this is set to 4096 with that number being 
> scattered in various places of the code.
> We should make this configurable. For this to work we need to store the 
> iteration count along with the password.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to