Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/43#discussion_r52073887
--- Diff: src/message.c ---
@@ -318,8 +318,10 @@ static int qd_check_and_advance(qd_buffer_t
**buffer,
int pre_consume = 1; // Count the already extracted tag
int consume = 0;
unsigned char tag = next_octet(&test_cursor, &test_buffer);
- if (!test_cursor) return 0;
- switch (tag & 0xF0) {
+ int tag_bit = tag & 0xF0;
--- End diff --
This looks ok. One minor change that's needed: tag is an unsigned char,
so tag_bit must be of the same type. Also, 0xF0 represents 4 bits so tag_bit
might not be the best name. The spec calls it a subcategory. Maybe use that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
