----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43500/#review119323 -----------------------------------------------------------
trunk/qpid/python/qpid/messaging/endpoints.py (line 47) <https://reviews.apache.org/r/43500/#comment180640> Please add Endpoint to __all__ at the bottom of the module so that Endpoint will be included in the docs explicitly. That will allow its docstrings to be shown also. trunk/qpid/python/qpid/messaging/endpoints.py (line 48) <https://reviews.apache.org/r/43500/#comment180647> Consider adding this into the @undocumented list also. It accepts no arguments so it's not something we need to tell users anything special about. If you do want to add it along with __setattr__ I tested that the following would work at the object docstring: @undocumented: __setattr_, __init__ trunk/qpid/python/qpid/messaging/endpoints.py (line 57) <https://reviews.apache.org/r/43500/#comment180641> Please move docstring here, and remove set_async_exception_notify_handler from Session, Connection, Receiver, and Sender trunk/qpid/python/qpid/messaging/endpoints.py (line 60) <https://reviews.apache.org/r/43500/#comment180643> Consider giving Endpoint the following docstring to hide its __setattr__ method: """ @undocumented: __setattr__ """ Consider adding a docstring back that explains that this calls the _async_exception_notify_handler when 'error' is set. trunk/qpid/python/qpid/messaging/endpoints.py (line 644) <https://reviews.apache.org/r/43500/#comment180644> This should have the object itself passed into the callback. We had talked about using inspect. After thinking it over I propose we start passing the object as an argument and if the registered handler is incompatible it will raise an exception that the handler doesn't accept enough arguments. In other words let normal Python error handling handle this for us. trunk/qpid/python/qpid/messaging/endpoints.py (line 731) <https://reviews.apache.org/r/43500/#comment180645> Please rename this function to: set_message_received_notify_handler - Brian Bouterse On Feb. 15, 2016, 7:15 p.m., Kenneth Giusti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43500/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2016, 7:15 p.m.) > > > Review request for qpid and Justin Ross. > > > Bugs: QPID-7053 > https://issues.apache.org/jira/browse/QPID-7053 > > > Repository: qpid > > > Description > ------- > > An application can use the python-qpid client API via a "semi-polled" > approach by leveraging the "message_received" callback registered to a > Session. This allows the app to do other things while waiting for a message > to arrive. However, if an error occurs in the background driver thread, the > app will never be notified. And since a message may never arrive due to the > error, the app can hang. > > This change allows the task to register a callback that is invoked when the > driver thread detects an error. This is in addition to the original behavior > - to raise the error when the app next calls into the API. The intent of the > callback is to cause the app to schedule itself to re-poll the API. > > > Diffs > ----- > > trunk/qpid/python/qpid/messaging/driver.py 1726802 > trunk/qpid/python/qpid/messaging/endpoints.py 1726802 > trunk/qpid/python/qpid/tests/messaging/endpoints.py 1726802 > trunk/qpid/python/setup.py 1726802 > > Diff: https://reviews.apache.org/r/43500/diff/ > > > Testing > ------- > > new tests added for the api > > > Thanks, > > Kenneth Giusti > >
