[
https://issues.apache.org/jira/browse/QPID-6969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193256#comment-15193256
]
Rob Godfrey commented on QPID-6969:
-----------------------------------
* As discussed offline, I think documentation should be added into the code as
metadata for all API methods, so I think we should do QPID-7140 and then add
the appropriate documentation inline.
* For testing, I'd favour refactoring to separate out the object querying /
results building code from anything to do with Http / Servlet we can then test
the core functionality without requiring mocking a servlet framework (or
alternatively only writing system tests).
* For the general auto-generated code issues, we previously made the decision
to not regenerate code on every build as the extra overhead on a per-build
basis seemed unnecessary when the grammar changed so infrequently (practically
never) similarly we've managed to avoid hand editing generated code for a
number of years already. Unfortunately I don't think it's necessarily easy to
have the parser generate comments into the other generated classes. I agree
that the general syntax of JavaCC is horrible and makes the entire thing very
difficult to reason about. For the most part the code in this change is only a
slightly modified copy of the JMS selector code - pretty much all comments here
apply equally well to that code.
* TokenMgrError - yeah that should be fixed (quite why JavaCC makes this a
freaking Error and not a ParseException I have no idea :-( )
> [Java Broker] Provide SQL-like querying functionality through the HTTP
> Management API
> -------------------------------------------------------------------------------------
>
> Key: QPID-6969
> URL: https://issues.apache.org/jira/browse/QPID-6969
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-6.1
>
> Attachments:
> 0001-QPID-6969-Java-Broker-Refactor-QueryServlet-performQ.patch
>
>
> For reporting and monitoring it is sometimes more convenient to provide more
> complex querying features than are currently supported by the REST API, and
> to limit the results brought back to be only certain attributes of the
> queried object.
> We should add mechanisms to query configured objects across the whole broker,
> or only those within a given virtual host (the latter including connections
> which are associated with a virtual host even though not directly children of
> that host - since connections are children of ports).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
