[
https://issues.apache.org/jira/browse/QPID-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193502#comment-15193502
]
Lorenz Quack commented on QPID-7066:
------------------------------------
* {{ConfiguredSettableAttribute}} and its subclasses have a typo in the method
name {{vaidValuePattern}}
* The error messages in {{ACO#onValidate}} are worded quite awkwardly. But they
are consistent.
* Currently setting the validValuePattern "foo" on a List of Integers means
they are all accepted. Would it not be more prudent to either throw an
exception if validValuePattern is not applicable or reject all values?
* Should the TODO in {{ApiDocsServlet.java}} be addressed? It's not a trivial
problem and we control the values but it feels like we should handle this
nevertheless.
> [Java Broker] Add a validValuePattern attribute to ManagedAttribute
> -------------------------------------------------------------------
>
> Key: QPID-7066
> URL: https://issues.apache.org/jira/browse/QPID-7066
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Priority: Minor
> Fix For: qpid-java-6.1
>
>
> Currently there is no way to convey through meta data that an attribute value
> must conform to a particular pattern (for instance in the case of a hostname
> or ip address).
> Where a managed attribute is of type String, the regex can be used both
> client and server side to validate the input. Client side validation will
> also always need to take into account that it is always legal to insert a
> context variable reference into the value... and where such a context
> injection is present is is effectively impossible to correctly validate on
> the client side.
> For attributes which are of type Collection<String>, List<String> or
> Set<String> the validValuePattern can be taken to be referring to the
> validation applied to each element of the collection.
> The annotation information should also be conveyed through the metadataservlet
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
