-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44805/
-----------------------------------------------------------
(Updated March 15, 2016, 9:29 p.m.)
Review request for qpid, Andrew Stitcher, Cliff Jansen, and Justin Ross.
Changes
-------
Code complete, needs doc.
Repository: qpid-proton-git
Description (updated)
-------
Provide free get<> and convert<> template functions to get the exact type from a
proton::value or to convert from the contained type if allowed. Retained get
members for backwards compatibility but marked deprecated.
Refactor - extracted proton::scalar_base for better re-use.
Added free get<T>(scalar) template to get exactly type T.
Added free convert<T>(scalar) template to do any legal C++ conversion to
type T.
Diffs (updated)
-----
examples/cpp/direct_recv.cpp ffb2f03cf4df9517158f6b07777e5d8e3ad387a6
examples/cpp/encode_decode.cpp 12fc1ed1ace5af84dbf67995ad7059d3df04350e
examples/cpp/engine/server.cpp 4641c4cb20b3c4bff4246649c2ee0929d14f3c35
examples/cpp/server.cpp 8ac34ccb65bd90ee81c3271c633d34f828b067f2
examples/cpp/server_direct.cpp 9d3b79c9531762a4a84c47dc9c9ede9cc32e09fd
proton-c/bindings/cpp/CMakeLists.txt 11b299d5c48fbdb39c1ee00e8f994649299f4ed2
proton-c/bindings/cpp/docs/CMakeLists.txt
cf7876e3db4f3a38f88e3e05e215a238f748cc7b
proton-c/bindings/cpp/docs/user.doxygen.in
e76337a57a6599486398c1bcc1ed69087b66f518
proton-c/bindings/cpp/include/proton/amqp.hpp
2ca122feec34f700e5f1e4f74438d994be8e1a43
proton-c/bindings/cpp/include/proton/annotation_key.hpp
61b643438fc08d1c92af195b10361baa745979a0
proton-c/bindings/cpp/include/proton/binary.hpp
e907f4769fafe62754609c1325e3bb4dbe9be8df
proton-c/bindings/cpp/include/proton/data.hpp
3d391541a849b4cc203145eba279daa07a3638f8
proton-c/bindings/cpp/include/proton/decoder.hpp
9a835c09c64f03cb07aaf66ff29b78ecf95f496d
proton-c/bindings/cpp/include/proton/encoder.hpp
c76c9ce3630b555503c84a729778f68437628d80
proton-c/bindings/cpp/include/proton/message_id.hpp
0def3270db3488da4e8f69edc6aa9a18572f06a3
proton-c/bindings/cpp/include/proton/scalar.hpp
dd55e95e97af5e74649e9acffb42f7116b4ca5fd
proton-c/bindings/cpp/include/proton/scalar_base.hpp PRE-CREATION
proton-c/bindings/cpp/include/proton/symbol.hpp
24a521326f0b906131395180340069eae9f28921
proton-c/bindings/cpp/include/proton/timestamp.hpp
00282dd75e859f4bbf7d9eba00e92e029f22a843
proton-c/bindings/cpp/include/proton/type_id.hpp
2d399a54f25086b393acc8e8f38085025926e941
proton-c/bindings/cpp/include/proton/type_traits.hpp
1000a63ac375c23b80164a23d8bbe68701ec3384
proton-c/bindings/cpp/include/proton/types.hpp
bb2017b0b6276424b233bd75db5581ac48bf8a11
proton-c/bindings/cpp/include/proton/value.hpp
e0b73176507b4ddca1fdf8b3e6f72c7ea37a933a
proton-c/bindings/cpp/src/decoder.cpp
890fac5eae9a4bad38223e1811fc17c2a1db6cff
proton-c/bindings/cpp/src/encoder.cpp
538decc03dd4268ed1933570f9ba8aefe3d0ca53
proton-c/bindings/cpp/src/interop_test.cpp
b05c098f4944f88b4a893c3d38451e6eebaf22d7
proton-c/bindings/cpp/src/message.cpp
6d95256bdde10fb79f8f5742f01f50780f8b597f
proton-c/bindings/cpp/src/message_test.cpp
8c1e585d42fe757b953a8ffb1a9ffe2b7567f9f5
proton-c/bindings/cpp/src/scalar.cpp b862af011855ccc23b4d289e64f599eefa894d2c
proton-c/bindings/cpp/src/scalar_base.cpp PRE-CREATION
proton-c/bindings/cpp/src/scalar_test.cpp
9b2df1f6c8f8debd6bbee203fce8e9342f539dac
proton-c/bindings/cpp/src/test_bits.hpp
d45739cc6121de512c9e4debd2cd192fe35647c5
proton-c/bindings/cpp/src/types_internal.hpp
c3ad1d45f1028adc06815f159d71d3089f8dc709
proton-c/bindings/cpp/src/value.cpp bece42c66c8b7394d29a2212a1b021ccfb552eb7
proton-c/bindings/cpp/src/value_test.cpp
be24da430cf76ac698e89fc57442c4cff30beae2
tests/tools/apps/cpp/reactor_send.cpp
3ba26e8aa608b6b218ec94d300b4dfd7da173eb8
Diff: https://reviews.apache.org/r/44805/diff/
Testing
-------
ctest -R cpp
Thanks,
Alan Conway
