Keith Wall created QPID-7142:
--------------------------------

             Summary: Add child refactoring
                 Key: QPID-7142
                 URL: https://issues.apache.org/jira/browse/QPID-7142
             Project: Qpid
          Issue Type: Improvement
          Components: Java Broker
            Reporter: Keith Wall


The add child function in the Broker is currently implemented on a per CO 
implementation basis.  This code should be standardised - probably pulled up,  
into {{ACO}}.

Currently each {{#addChild}} implementation knows about its supported child 
types.  This duplicates the information from the Model.   This should be 
changed so that it is driven from the model.

Also some objects have restrictions on supported child types too 
{{ManagedObject#validChildTypes}}.    This is currently expressed only through 
the metadata.  This information should be utilised by the generic addChild 
function to automatically reject a child of the wrong type.

There is some tricky code in Bindings that might need to be considered first.

Currently if I try to create a child of the wrong type, this is reported to the 
REST user as a 500.  This seems wrong.





--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to