[ 
https://issues.apache.org/jira/browse/QPID-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15201356#comment-15201356
 ] 

Keith Wall commented on QPID-6995:
----------------------------------

On the whole looks good.

On niggle with the inconsistency in the exception handling between 
NonJavaKeyStoreImpl#checkCertificateExpiry() and 
FileKeyStoreImpl#checkCertificateExpiry.  The latter swallows NPE from the 
whole method (into which a programming error could fall).  I guess you were 
intending to catch NPE/IAE around the getContextValue only in the same way you 
have done AbstractKeyStore#initializeExpiryChecking.






> [Java Broker] Keystores should warn of pending certificate expiration
> ---------------------------------------------------------------------
>
>                 Key: QPID-6995
>                 URL: https://issues.apache.org/jira/browse/QPID-6995
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-6.1
>
>
> Keystores should have the ability to warn that a certificate is pending 
> expiry. 
> This would take the form of an operation log message which is written 
> regularly to the log, say on a day interval once a certificate reaches a 
> certain proximity to its expiration date.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to