[ 
https://issues.apache.org/jira/browse/QPID-7161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210647#comment-15210647
 ] 

ASF subversion and git services commented on QPID-7161:
-------------------------------------------------------

Commit 1736479 from [~k-wall] in branch 'java/trunk'
[ https://svn.apache.org/r1736479 ]

QPID-7161: [Java Broker] Remove the shutdown hook earlier in closing sequence

> System test output lost owing to orphaned shutdown hooks
> --------------------------------------------------------
>
>                 Key: QPID-7161
>                 URL: https://issues.apache.org/jira/browse/QPID-7161
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker, Java Tests
>            Reporter: Keith Wall
>            Priority: Minor
>
> When the Broker exits, normally {{AbstractSystemConfig}} organises for the 
> shutdown hook to be removed ({{#onClose}}).  If {{AbstractSystemConfig}} 
> fails to close all its children, the step to remove the shutdown hook never 
> gets executed.  For normal production use cases this is harmless; the Broker 
> is going down anyway.  However when testing the Broker using its system test 
> suite this is problematic.
> Our Logback configuration associates threads to test specific log file.  The 
> ShutdownHook still maintains this association, even though QpidTestCase has 
> already told Logback that the test is through {{org.slf4j.MDC#remove}}.  As 
> Logback believes the test is through, when the Shutdown hook awakes and logs, 
> Logback truncates the tests' logfiles, removing the details of why the test 
> actually failed in the first place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to