[
https://issues.apache.org/jira/browse/QPID-7158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245469#comment-15245469
]
Alex Rudyy commented on QPID-7158:
----------------------------------
Here are my review comments:
AttributeAnnotationValidator:
The block bellow is already present in AttributeAnnotationValidator and needs
deletion:
{code}
+
+
if(typeUtils.isSameType(type,elementUtils.getTypeElement("java.util.Date").asType()))
+ {
+ return true;
+ }
{code}
NonJavaKeyStoreImpl:
certificateValidEnd
{code}
return _certificate == null ? new Date(0) : _certificate.getNotAfter();
{code}
certificateValidStart
{code}
return _certificate == null ? new Date(0) : _certificate.getNotBefore();
{code}
I would prefer to return null when _certificate is null rather than new Date(0).
SiteSpecificTrustStoreImpl returns null for similar attributes. We should be
consistent acrross different trust/key store implementations
ConfiguredObject:
The type of derived attribute lastOpenedTime should be changed to Date
org.apache.qpid.server.security.CertificateDetails:
long getValidFrom();
long getValidUntil();
Should methods above return Date?
> [Java Broker] Change type of datetime management attributes from Long to
> java.util.Date
> ---------------------------------------------------------------------------------------
>
> Key: QPID-7158
> URL: https://issues.apache.org/jira/browse/QPID-7158
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Alex Rudyy
> Fix For: qpid-java-6.1
>
>
> It is unclear from metadata that datetime attribute having type Long
> actually represent datetime values. We need to change datetime attributes
> type from Long to java.util.Date which can still be serialized into json as
> long values
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
