----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48362/#review136551 -----------------------------------------------------------
You need to compile this code with C++03 and fix up the places that end up needing a feature macro to avoid breakage. examples/cpp/scheduled_send.cpp (line 29) <https://reviews.apache.org/r/48362/#comment201622> This is C++11 only don't need "fake_cpp11.hpp", and can just use "override" directly. examples/cpp/scheduled_send.cpp (line 44) <https://reviews.apache.org/r/48362/#comment201623> Yep that's a good idea, lets add double constructors to duration (just not as pzrt of this change) examples/cpp/scheduled_send.cpp (line 54) <https://reviews.apache.org/r/48362/#comment201627> Should be able to combine into a single line with no loss of readability (IMO): One common style seems to be - ``` c.schedule(timeout, [this]() { this->cancel(); }); ``` examples/cpp/scheduled_send.cpp (line 89) <https://reviews.apache.org/r/48362/#comment201630> Should the delay here take account of the actual now time? In other words, are we trying for a fixed frequency or an "at least" delay? proton-c/bindings/cpp/include/proton/container.hpp (line 201) <https://reviews.apache.org/r/48362/#comment201631> Need to add a new feature flag I'll need to look up the actual name, but PN_CPP_HAS_STD_FUNCTION will do for now. proton-c/bindings/cpp/src/container_impl.cpp (line 170) <https://reviews.apache.org/r/48362/#comment201632> As above use a specific feature macro. - Andrew Stitcher On June 7, 2016, 9:23 p.m., Alan Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48362/ > ----------------------------------------------------------- > > (Updated June 7, 2016, 9:23 p.m.) > > > Review request for qpid, Andrew Stitcher, Cliff Jansen, and Justin Ross. > > > Repository: qpid-proton-git > > > Description > ------- > > PROTON-1221: c++ container::schedule() support. > > > Diffs > ----- > > examples/cpp/CMakeLists.txt 06ec1a49c00a98c3a602c9b6e76bf311345c397b > examples/cpp/README.dox 897b302da0c0c132093b5f9977d28ac274cfeea9 > examples/cpp/mt/epoll_container.cpp > feea3007a8b732a47177a50d6ff385f9d60f1a63 > examples/cpp/scheduled_send.cpp PRE-CREATION > proton-c/bindings/cpp/include/proton/container.hpp > 9665346cef187fccf59049ea4f5ce927dd46b60b > proton-c/bindings/cpp/include/proton/default_container.hpp > f50869cb28b9d94784ab3329dcec43085eab4393 > proton-c/bindings/cpp/src/container_impl.hpp > 8fd64d00c4191c34ec3e6dd5da32c121f8ad2718 > proton-c/bindings/cpp/src/container_impl.cpp > ce6a2b2a097795d49f40e4a962e91db9222588f0 > proton-c/bindings/cpp/src/test_dummy_container.hpp > 730790140bea671796032b4daa95492ed1c17c25 > > Diff: https://reviews.apache.org/r/48362/diff/ > > > Testing > ------- > > > Thanks, > > Alan Conway > >
