[
https://issues.apache.org/jira/browse/QPID-7305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339417#comment-15339417
]
Lorenz Quack commented on QPID-7305:
------------------------------------
My review comments:
* The private AbstractQueue#parseSelector is unfortunatly placed in between
public methods
* formatting on CopyMessagesTransaction and MoveMessagesTransaction is of.
parameters should be on separate lines
* I object to limit == 0 meaning unlimited in QueueEntryTransaction. I am of
the opinion that a limit == 0 has a well defined meaning: Return 0 entries.
Whether that is useful or not, I think arbitrarily changing well defined
semantics is a mistake. Obviously if this is changed the anonymous
QueueEntryVisitor in QueueEntryTransaction needs to change as well.
* no tests :(
* no documentation :(
> [Java Broker] Queue operations copy/move/delete should take an optional JMS
> selector argument
> ---------------------------------------------------------------------------------------------
>
> Key: QPID-7305
> URL: https://issues.apache.org/jira/browse/QPID-7305
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Keith Wall
> Fix For: qpid-java-6.1, qpid-java-6.0.4
>
>
> The Queue defines three operations which act on a provided subset of the
> messages on the queue: copy/move/delete.
> The caller of the operation must provide a list of (internal) message-ids on
> which they wish the operation to be performed.
> It would be useful to be able to supply a JMS selector in addition / in place
> of the list of message ids. This would allow a user to construct a selective
> query as to which messages get moved/copied/deleted (or simply
> move/copy/delete all messages in the queue).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
