[ 
https://issues.apache.org/jira/browse/QPID-7308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15350713#comment-15350713
 ] 

Lorenz Quack commented on QPID-7308:
------------------------------------

Hi Alex,

thanks for addressing my comments. Seems to work now.

Two minor comments that do not need to be actioned. Just for the record:
* You misread my comment about pressing the space bar when the focus is on the 
page size drop down. I said it does not *open* the drop down menu. But I guess 
that this is probably a dojo/firefox issue and not something you can do 
anything about. As mentioned before, it works in chromium.
* Another issue I noticed, which I also think is out of our hands, is that the 
drag and drop behaviour is a bit misleading. The box attached showing the drag 
information goes green when you move the mouse to another column but dropping 
it there might not actually change the order of the column. It only reorders 
them if you drag to the opposite half of that column. There is actually a 
indicator between columns showing where the dragged columns will be dropped but 
this is easy to miss since the colour indicator on the drag box is a much 
stronger visual stimulus (at least IMHO). Again, I don't think this is 
important enough to raise with the dgrid team. just an oddity I noticed.
 

> [Java Broker] Improve Query UI functionality and look 
> ------------------------------------------------------
>
>                 Key: QPID-7308
>                 URL: https://issues.apache.org/jira/browse/QPID-7308
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: qpid-java-6.1
>            Reporter: Alex Rudyy
>            Assignee: Lorenz Quack
>             Fix For: qpid-java-6.1
>
>         Attachments: query issues.png
>
>
> The following improvements need to be done in Query UI:
> # Within pagination area, the current page should be given prominence
> # Simple query should have default columns.  Initially these could be 
> hardcoded.  Eventually, this could be driven by  a preference
> # Change wording of the warning when switching to advanced mode
> # Exclamation icon is off-centre.   Are there icons from the new theme we can 
> use?
> # Text box alignment
> # Columns should be re-orderable by dragging in standard mode only
> # Remove a column with fewer clicks - nice to have
> # Query UI not fully keyboard traversal-able
> ** fix sorting with keyboard
> ** fix clicking through the rows
> # Errors in SQL syntax are not reported to the user
> # The same columns can be selected 2 times in column drop down select



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to