[
https://issues.apache.org/jira/browse/DISPATCH-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15351523#comment-15351523
]
ASF GitHub Bot commented on DISPATCH-373:
-----------------------------------------
GitHub user ganeshmurthy opened a pull request:
https://github.com/apache/qpid-dispatch/pull/85
DISPATCH-373 - Added appropriate error messages for AMQP_NOT_FOUND me…
…ssages. Added logging got linkRoute, address and autoLink
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-373
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit 48e99e5c345a12e9d1332bf2c22c557295808c8c
Author: Ganesh Murthy <[email protected]>
Date: 2016-06-27T18:21:06Z
DISPATCH-373 - Added appropriate error messages for AMQP_NOT_FOUND
messages. Added logging got linkRoute, address and autoLink
----
> qdmanage : no clear error message when "read" type linkRoute, address and
> autoLink
> ----------------------------------------------------------------------------------
>
> Key: DISPATCH-373
> URL: https://issues.apache.org/jira/browse/DISPATCH-373
> Project: Qpid Dispatch
> Issue Type: Bug
> Affects Versions: 0.6.0
> Reporter: Paolo Patierno
> Assignee: Ganesh Murthy
>
> Executing a bad request with "read" operation (only ---type option) produces
> following results for linkRoute, address and autoLink :
> [root@localhost /]# qdmanage -b localhost:5673 read --type linkRoute
> BadRequestStatus: Bad Request
> [root@localhost /]# qdmanage -b localhost:5673 read --type address
> BadRequestStatus: Bad Request
> [root@localhost /]# qdmanage -b localhost:5673 read --type autoLink
> BadRequestStatus: Bad Request
> and the router doesn't produce any error or output on the console.
> Instead, using another type, for example connector produces following result :
> [root@localhost /]# qdmanage -b localhost:5673 read --type connector
> BadRequestStatus: No name or identity provided
> with a clearer error on what user misses on the command line.
> At same time the router output shows following error to the console :
> Thu Jun 9 07:26:13 2016 AGENT (error) Error dispatching
> Message(address=None, properties={'operation': 'READ', 'type':
> 'org.apache.qpid.dispatch.connector'}, body={},
> reply_to='amqp:/_topo/0/Router.A/temp.JJRdbcd9RbPxemN', correlation_id=1L):
> No name or identity provided
> Traceback (most recent call last):
> File
> "/usr/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py",
> line 790, in receive
> status, body = self.handle(request)
> File
> "/usr/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py",
> line 815, in handle
> target = self.find_entity(request)
> File
> "/usr/lib/qpid-dispatch/python/qpid_dispatch_internal/management/agent.py",
> line 892, in find_entity
> raise BadRequestStatus("No name or identity provided")
> BadRequestStatus: No name or identity provided
> I guess that for all types provided, missing name or identity, the behavior
> should be the same.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
