[
https://issues.apache.org/jira/browse/QPID-7349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15372845#comment-15372845
]
Lorenz Quack commented on QPID-7349:
------------------------------------
sorry for being so pedantic but the comment in the line just above the one you
changed is now no longer correct
{code}// Reduce the minimum delta and number of runs so that test executes more
quickly.We are not interested in an accurate repeatable value in this test.
arguments.put(HILL_CLIMBER_MINIMUM_DELTA, "64000");{code}
The minimum delta was not reduced but actually increased (in combination with
the other change it should still have the desired effect).
Maybe that comment should be more generic. Something along the lines of "Change
default parameters to execute more quickly"
Also (if you are going to make another change anyway) I would move the
{{arguments.put(HILL_CLIMBER_START_TARGET_RATE, "131073");}} next to the line
mentioned above since they are somewhat related.
> [Java Tests] Test EndToEndTest.testHillClimbing failed to achieve target
> thresholds during one iteration and failed
> -------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-7349
> URL: https://issues.apache.org/jira/browse/QPID-7349
> Project: Qpid
> Issue Type: Test
> Components: Java Performance Tests, Java Tests
> Reporter: Alex Rudyy
> Assignee: Keith Wall
>
> Test EndToEndTest.testHillClimbing failed to achieve target thresholds during
> one iteration and failed as below:
> {noformat}
> Unexpected number of lines in CSV expected:<6> but was:<1>
> Stacktrace
> junit.framework.AssertionFailedError: Unexpected number of lines in CSV
> expected:<6> but was:<1>
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.Assert.failNotEquals(Assert.java:329)
> at junit.framework.Assert.assertEquals(Assert.java:78)
> at junit.framework.Assert.assertEquals(Assert.java:234)
> at junit.framework.TestCase.assertEquals(TestCase.java:401)
> at
> org.apache.qpid.systest.disttest.endtoend.EndToEndTest.testHillClimbing(EndToEndTest.java:182)
> {noformat}
> The results have not been written into CSV file because test thresholds have
> not been achieved :
> {noformat}
> 2016-07-10 22:00:44,957 INFO [main] o.a.q.d.c.HillClimbingTestRunner
> Completed test unsuccessfully, run number 1/1, result
> TestResult{_name='HillClimbing', _hasErrors=false, _producedMessageRate=1.0,
> _consumedMessageRate=0.774593338497289}, target rate : 1.0, production to
> target ratio : 100.0%, consumption to production ratio : 77.5%.
> 2016-07-10 22:00:44,957 INFO [main] o.a.q.d.c.HillClimbingTestRunner
> Target throughput (1.0) missed.
> 2016-07-10 22:00:44,957 WARN [main] o.a.q.d.c.Controller Finished
> test TestInstance[testName=HillClimbing, iterationNumber=0] without producing
> a result.
> 2016-07-10 22:00:44,957 INFO [main] o.a.q.d.r.ResultsCsvWriter Wrote
> 0 test result(s) to output file
> /tmp/EndToEndTest.testHillClimbing_1468188037533/hillclimbing.csv
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
