[ 
https://issues.apache.org/jira/browse/QPID-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392761#comment-15392761
 ] 

Keith Wall commented on QPID-7276:
----------------------------------

Hi Lorenz, 

Looks good to me. One comment:

# MessageInfo#getNotValidBefore I think if notValidBefore is unset, the 
attribute should be null rather than 1st Jan 1970.  This would make the 
property behave like {{expirationTime}} and {{timestamp}} which return null 
rather than 0.  Separately I can't see why {{expirationTime}} and {{timestamp}} 
 still return Longs.  I think these should have been changed into Dates 
(probably should have been part of QPID-7158).

> [Java Broker] Message delay UI improvements
> -------------------------------------------
>
>                 Key: QPID-7276
>                 URL: https://issues.apache.org/jira/browse/QPID-7276
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>             Fix For: qpid-java-6.1
>
>         Attachments: 
> 0001-QPID-7276-Java-Broker-WMC-WIP-Add-UI-for-message-del.patch
>
>
> QPID-7255 introduced support of message delays.  To make the feature more 
> useful/usable, the following additions are identified:
> # Extend the Queue UI to allow {{holdOnPublishEnabled}} to be enabled when 
> creating or updating a queue.  
> # Reveal through the UI when a Queue Entry is held.
> # Make the Message content UI treat {{NotValidBefore}} as a date/time.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to