[
https://issues.apache.org/jira/browse/QPID-7328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397609#comment-15397609
]
Lorenz Quack commented on QPID-7328:
------------------------------------
Hi Alex,
* In {{Broker.java}} and {{ConsoleHelper.js}} I would prefer https over http. I
think I would also drop the "index.html" from the end but that is just personal
preference.
* We might want to consider renaming the context and menut to "Documentation",
rather than "Help". With "help" I would expect an email contact, IRC, user
forum, FAQ, or similar.
* In {{BrokerRestTest#testEffectiveInheritedContext}} you can reuse
{{SYSTEM_PROPERTY_NAME}} and {{SYSTEM_PROPERTY2_NAME}}
* In {{ConfiguredObjectToMapConverterTest}} you added testing of the
interpolation functionality into {{testExcludeInheritedContext}} I think it is
a distinct enough feature to go into a test of its own resulting in two smaller
more focused tests.
* I realise that this is old behaviour but
{{ConfiguredObjectToMapConverter#collectInheritedActualContext}} seems to only
inherit the context of the first parent. Could this not be a problem for COs
with multiple parents. I guess the answer is "yes" but we don't care about
those cases ;) .
> [Java Broker, WMC] The Help Menu link in the WMC is broken
> ----------------------------------------------------------
>
> Key: QPID-7328
> URL: https://issues.apache.org/jira/browse/QPID-7328
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.1
> Reporter: Lorenz Quack
> Assignee: Lorenz Quack
> Fix For: qpid-java-6.1, qpid-java-6.0.5
>
>
> The link contains an uninterpolated "${qpid.version}"
> Changes committed as part of QPID-7211 introduced a bug in evaluation and
> reporting of context variables via REST: values for default context variables
> and context variables coming from JVM properties and environment variables
> are not interpolated in the REST responses. The issue does not affect Broker
> internal use of context variables.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
