[
https://issues.apache.org/jira/browse/QPID-7318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15399817#comment-15399817
]
Rob Godfrey commented on QPID-7318:
-----------------------------------
h4. Patch 5
{quote}
* SystemPrincipalSource is currently only used by tests. Should the
SystemConfig not be a SystemPrincipalSource?
{quote}
Nope - see the reasoning above about AccessControlSource. This interface is
there purely to allow mock objects to be used in the tests.
h4. Patch 6
{quote}
* ConfigurationSecretEncrypterSource is not used.
{quote}
I added it simply for completeness for when a test using mocking runs into the
same issues that required AccessControlSource and SystemPrincipalSource
h4. Patch 7 (Show priority in web console, order children according to priority
in output)
{quote}
* currently all AccessControlProvider have the default priority so they will be
ordered by name.
{quote}
Indeed - but currently I wouldn't expect anyone to have more than one
provider... and if they do they should make sure they set the priority to
properly reflect the order they wish them to be applied in.
> [Java Broker] Refactor existing ACL plugin code
> -----------------------------------------------
>
> Key: QPID-7318
> URL: https://issues.apache.org/jira/browse/QPID-7318
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-6.1
>
>
> While the aim is to redesign the ACL implementation in the v6.2 or v7.0
> timeframe, there is still utility in tidying up the existing ACL
> implementation a bit. In particular by separating out functions and
> providing a better encapsulation, we will make the job of writing automated
> upgraders to any new ACL implementation substantially easier.
> As a first step we can separate out the parsing of the ACL file, from the
> "rule based" implementation of ACLs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
