----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50989/ -----------------------------------------------------------
Review request for qpid, Andrew Stitcher, Cliff Jansen, and Justin Ross. Repository: qpid-proton-git Description ------- PROTON-1277: pn_connection_engine to use pn_bytes_t and pn_rwbytes_t Removed types pn_buf_t and pn_wbuf_t, replaced with existing pn_bytes_t and new pn_rwbytes_t for consistency. PROTON-1277: pn_connection_engine to allow external buffers Extended the pn_connection_engine interface with use_read/write_buffer functions to allow an external buffer to be used. API allows user-controlled buffer re-allocation. I tried for a "neater" interface but it didn't work out. For async write you have to separate "get the data" and "all done with the data" so you can't really make it simpler than it is, and you need to be able to grow both buffers so you can't really do much to simplify the read side. For reads the transport moves data around to accumulate complete frames, so you still have to ask "where is the readable bit" even if you supplied the buffer. No implementation yet. I feel like we need a clearer idea of what we are trying to achieve before we commit. This proposal is backwards compatible which takes some of the pressure off about deciding when to add it. Diffs ----- proton-c/bindings/cpp/src/io/connection_engine.cpp f15b019b4637971509d9970024236ead10537778 proton-c/bindings/go/src/qpid.apache.org/proton/engine.go 5b9dbf069baf491c4b11459da7a27a438253a396 proton-c/include/proton/connection_engine.h 4fdeb85713e89256223efc5e93d27c4cb3e37a6b proton-c/include/proton/types.h 3f2ebcbcca058fc9c5a2e4b0d7ef9f754bc069f0 proton-c/src/engine/connection_engine.c 75a16ae7c09dcaa46525eee59a225868d5897483 proton-c/src/types.c 5433e193bbef31f1e426fe4f286dadac9d9dc64c Diff: https://reviews.apache.org/r/50989/diff/ Testing ------- ctest -E java|python Thanks, Alan Conway
