[ 
https://issues.apache.org/jira/browse/QPID-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alex Rudyy updated QPID-7340:
-----------------------------
    Assignee: Lorenz Quack
      Status: Open  (was: Reviewable)

Lorenz,

Here are my review comments:

Modifying preferences operations( like update or delete, etc) should be 
performed in preference thread. The purgeUser operation implementation uses 
configuration thread for preferences removal. I think that it is wrong.
I am wondering whether operation purgeUser should perform user deletion from 
authentication provider and group providers on configuration thread and than 
submit task to traverse the CO tree and perform the preferences removal in 
preferences thread.
I think that purgeUser should not wait for preference task and return after 
task submission in order to avoid blocking the configuration thread with 
auxiliary operations. 

Using Queue object for a single threaded operation looks like an unusual 
choice. I would personally use recursion for traversing the tree. 


> Implement purge user managed operation
> --------------------------------------
>
>                 Key: QPID-7340
>                 URL: https://issues.apache.org/jira/browse/QPID-7340
>             Project: Qpid
>          Issue Type: New Feature
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Lorenz Quack
>             Fix For: qpid-java-6.1
>
>
> When a human user leaves an organisation, it is normally desirable to remove 
> the records that belong to that user.  Implement an operation to allow a 
> named user to be removed.  This could be hooked to to an organisation's 
> 'leavers-feed'.
> This operation should remove:
> * preferences
> * for authentication providers that manage their own database, the user's 
> password entry
> * for group providers that manage their own database, remove the user from 
> any groups
> What ACL permission should protect this operation?
> What if a Virtualhost is offline at the time the operation is invoked?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to