[
https://issues.apache.org/jira/browse/PROTON-1287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15439703#comment-15439703
]
ASF subversion and git services commented on PROTON-1287:
---------------------------------------------------------
Commit ba8639fb7325a91d29f356a4e095cb0ae4c7888d in qpid-proton's branch
refs/heads/master from [~aconway]
[ https://git-wip-us.apache.org/repos/asf?p=qpid-proton.git;h=ba8639f ]
PROTON-1287: c++: missing empty() method on message_id, annotation_key
Added empty() to scalar_base(), since all restricted scalar types can be missing
in a message, so they need to allow the possibility of empty()
Moved internal::scalar_base to proton::scalar_base as it provides part of the
public API.
Moved internal::value_base::empty() and type() to proton::value. There's no
need for them
to be on the internal class and they are public API.
Added unit tests to confirm default values on proton::message, esp. empty
scalar values.
> c++: missing empty() method on message_id and annotation_key
> ------------------------------------------------------------
>
> Key: PROTON-1287
> URL: https://issues.apache.org/jira/browse/PROTON-1287
> Project: Qpid Proton
> Issue Type: Bug
> Components: cpp-binding
> Affects Versions: 0.14.0
> Reporter: Alan Conway
> Assignee: Alan Conway
> Fix For: 0.15.0
>
>
> The restricted scalar types message_id and annotation_key do not have an
> empty() method. This is needed because they can be absent on a message.
> It was also noted that both value and scalar type() and empty() methods are
> inherited (publicly) from internal classes, which makes it unclear if they
> part of the API and means doxygen does not document them.
> Fix this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
