Robbie Gemmell created PROTON-1300:
--------------------------------------
Summary: [proton-j] remove redundant credit update call
Key: PROTON-1300
URL: https://issues.apache.org/jira/browse/PROTON-1300
Project: Qpid Proton
Issue Type: Task
Components: proton-j
Affects Versions: 0.14.0
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Priority: Trivial
Fix For: 0.15.0
In TransportImpl.processSenderFlow() there is a redundant call to update the
transportLink credit value to be 0 while draining the link,
{noformat}
transportLink.setLinkCredit(UnsignedInteger.valueOf(0));
transportLink.setDeliveryCount(transportLink.getDeliveryCount().add(credits));
transportLink.setLinkCredit(UnsignedInteger.ZERO);
{noformat}
These methods have no side effects, just simple setters/getters, and the same
value is set twice, so this change just avoids it looking odd.
Credit [~tabish121] for spotting it :)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
