[
https://issues.apache.org/jira/browse/DISPATCH-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15490471#comment-15490471
]
ASF GitHub Bot commented on DISPATCH-498:
-----------------------------------------
Github user ganeshmurthy commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/98#discussion_r78749765
--- Diff: src/connection_manager.c ---
@@ -359,24 +359,21 @@ void
qd_connection_manager_free(qd_connection_manager_t *cm)
qd_config_listener_t *cl = DEQ_HEAD(cm->config_listeners);
while (cl) {
DEQ_REMOVE_HEAD(cm->config_listeners);
- qd_server_listener_free(cl->listener);
qd_server_config_free(&cl->configuration);
- free(cl);
+ qd_config_listener_free(cm, cl);
--- End diff --
This is an additional bug I found. free(cl) and free(cc) were called
instead of qd_config_listener_free(cm, cl) and qd_config_connector_free(cm, cc)
respectively. I fixed that in this method.
> memory leak in _configure_ssl_profile error path
> ------------------------------------------------
>
> Key: DISPATCH-498
> URL: https://issues.apache.org/jira/browse/DISPATCH-498
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Management Agent
> Affects Versions: 0.6.1
> Reporter: Chuck Rolke
> Assignee: Ganesh Murthy
> Fix For: 0.7.0
>
>
> As ssl_profile is constructed the CHECK() macro might jump to the error
> handler. There the ssl_profile is simply freed. Any strings referenced by
> ssl_profile are orphaned. Call qd_config_ssl_profile_free() instead of simple
> free().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
