Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/98#discussion_r79173208
  
    --- Diff: src/connection_manager.c ---
    @@ -486,11 +483,8 @@ void 
qd_connection_manager_delete_listener(qd_dispatch_t *qd, void *impl)
     bool qd_connection_manager_delete_ssl_profile(qd_dispatch_t *qd, void 
*impl)
     {
         qd_config_ssl_profile_t *ssl_profile = (qd_config_ssl_profile_t*) impl;
    -    if(ssl_profile) {
    -        bool freed = qd_config_ssl_profile_free(qd->connection_manager, 
ssl_profile);
    -
    -        return freed;
    -    }
    +    if(ssl_profile)
    --- End diff --
    
    This looks wrong.  Shouldn't it be if (!ssl_profile) ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to