Github user gemmellr commented on the issue:

    https://github.com/apache/qpid-jms/pull/4
  
    Thanks Jens,
    
    The resultant manifest looks to allow for any Netty 4 version, but I 
believe there are some incompatible changes in Netty 4.1.x already so changing 
to allow only 4.0.x would be good. Similarly, its probably wise to restrict 
proton-j to 0.14.x currently as well. If you could also add the JIRA ID 
(QPIDJMS 164, with a - inbetween) to the start of your commit message that will 
associate them and cause a comment on the JIRA with the details when merged. 
Feel free to squash the changes.
    
    In future if creating a PR, if you include the JIRA key in the title then 
the PR will be associated too (doesn't work when updating though so no need 
this time).
    
    Robbie


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to