[
https://issues.apache.org/jira/browse/DISPATCH-160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15514007#comment-15514007
]
ASF GitHub Bot commented on DISPATCH-160:
-----------------------------------------
Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/101#discussion_r80100058
--- Diff: include/qpid/dispatch/iterator.h ---
@@ -180,6 +180,8 @@ void qd_address_iterator_set_phase(qd_field_iterator_t
*iter, char phase);
*/
void qd_address_iterator_override_prefix(qd_field_iterator_t *iter, char
prefix);
+void qd_address_iterator_set_length(qd_field_iterator_t *iter, int length);
--- End diff --
Two things: This function should be a "qd_field_iterator..." function, not
a "qd_address_iterator..." function. There is nothing address-specific about
this operation.
Also, it might be clearer to call this "qd_field_iterator_trim" with an
argument called "new_length". This suggests that the length can only be
reduced.
> Dispatch router does not propagate custom message annotations
> -------------------------------------------------------------
>
> Key: DISPATCH-160
> URL: https://issues.apache.org/jira/browse/DISPATCH-160
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Router Node, Routing Engine
> Affects Versions: 0.4
> Reporter: Ganesh Murthy
> Assignee: Ganesh Murthy
> Priority: Critical
> Fix For: 0.7.0
>
>
> Steps to reproduce -
> Create an AMQP message with a custom message annotation -
> ma['custom-annotation'] = 'Custom_Annotation Content'
> Send this message via a dispatch router and receive this message. The
> received message does not contain the 'custom-annotation'.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
