Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/103#discussion_r80685950
--- Diff: CMakeLists.txt ---
@@ -51,6 +51,10 @@ set (SO_VERSION_MAJOR 2)
set (SO_VERSION_MINOR 0)
set (SO_VERSION "${SO_VERSION_MAJOR}.${SO_VERSION_MINOR}")
+set (QPID_DISPATCH_VERSION_MAJOR 0)
--- End diff --
The CMake file already passes the version from VERSION.txt into the set of
defined macros in config.h. I don't think it's desirable to create yet another
authoritative source-of-version that needs to be maintained manually on each
release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
