[
https://issues.apache.org/jira/browse/DISPATCH-451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15546459#comment-15546459
]
ASF GitHub Bot commented on DISPATCH-451:
-----------------------------------------
Github user ChugR commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/106#discussion_r81838943
--- Diff: include/qpid/dispatch/server.h ---
@@ -418,6 +418,22 @@ typedef struct qd_server_config_t {
uint32_t max_frame_size;
/**
+ * The max_sessions value is the number of sessions allowed on the
Connection.
+ * This value minus one is the Open performative channel-max setting.
+ */
+ uint32_t max_sessions;
+
+ /**
+ * The max_session_window value is the maximum number of outstanding
octets that are
--- End diff --
Good suggestion. The setting down to proton would be <this setting value> *
max-frame-size octets.
There is an identical setting in policy that operates this way, too. Again,
they ought to be the same either way.
> [AMQP] Hard coded session capacity should be configurable
> ---------------------------------------------------------
>
> Key: DISPATCH-451
> URL: https://issues.apache.org/jira/browse/DISPATCH-451
> Project: Qpid Dispatch
> Issue Type: Bug
> Components: Container
> Affects Versions: 0.6.0
> Reporter: Chuck Rolke
>
> In container.c and policy.c
> {noformat}
> pn_session_set_incoming_capacity(link->pn_sess, 1000000);
> {noformat}
> could be improved.
> Policy provides settable values for Open/maxFrameSize, Open/maxSessions,
> Begin/incoming_window, Attach/maxMessageSize. Configuration settings for
> these are also desirable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
