[
https://issues.apache.org/jira/browse/QPID-7462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15611558#comment-15611558
]
Keith Wall commented on QPID-7462:
----------------------------------
This commit caused a regression. This is being highlighted by the Joram tests
against the experimental client.
The code assumes that an attachment's capabilities will be none null. As
capabilities are optional [1], this assumption is unsafe.
[1]
http://docs.oasis-open.org/amqp/core/v1.0/os/amqp-core-transport-v1.0-os.html#type-attach
{noformat}
016-10-27 11:52:21,042 WARN [IO-/127.0.0.1:50228] (o.a.q.s.p.v.f.FrameHandler)
- Unexpected exception handling frame
java.lang.NullPointerException: null
at java.util.Objects.requireNonNull(Objects.java:203) ~[na:1.8.0_101]
at java.util.Arrays$ArrayList.<init>(Arrays.java:3813) ~[na:1.8.0_101]
at java.util.Arrays.asList(Arrays.java:3800) ~[na:1.8.0_101]
at
org.apache.qpid.server.protocol.v1_0.ConsumerTarget_1_0.isPullOnly(ConsumerTarget_1_0.java:88)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.ConsumerTarget_1_0.<init>(ConsumerTarget_1_0.java:78)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.SendingLink_1_0.<init>(SendingLink_1_0.java:170)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.Session_1_0.remoteLinkCreation(Session_1_0.java:811)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.Session_1_0.receiveAttach(Session_1_0.java:253)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0$1.run(AMQPConnection_1_0.java:293)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at java.security.AccessController.doPrivileged(Native Method)
[na:1.8.0_101]
at
org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0.receiveAttach(AMQPConnection_1_0.java:288)
[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.type.transport.Attach.invoke(Attach.java:350)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0.receive(AMQPConnection_1_0.java:309)
[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.framing.FrameHandler.parse(FrameHandler.java:166)
~[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0$10.run(AMQPConnection_1_0.java:1167)
[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at java.security.AccessController.doPrivileged(Native Method)
[na:1.8.0_101]
at
org.apache.qpid.server.protocol.v1_0.AMQPConnection_1_0.received(AMQPConnection_1_0.java:1140)
[qpid-broker-plugins-amqp-1-0-protocol-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.MultiVersionProtocolEngine.received(MultiVersionProtocolEngine.java:142)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.NonBlockingConnection.processAmqpData(NonBlockingConnection.java:624)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.NonBlockingConnectionPlainDelegate.processData(NonBlockingConnectionPlainDelegate.java:58)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.NonBlockingConnection.doRead(NonBlockingConnection.java:512)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.NonBlockingConnection.doWork(NonBlockingConnection.java:285)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.NetworkConnectionScheduler.processConnection(NetworkConnectionScheduler.java:126)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.SelectorThread$ConnectionProcessor.processConnection(SelectorThread.java:561)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.SelectorThread$SelectionTask.performSelect(SelectorThread.java:352)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.SelectorThread$SelectionTask.run(SelectorThread.java:97)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
org.apache.qpid.server.transport.SelectorThread.run(SelectorThread.java:519)
[qpid-broker-core-6.2.0-SNAPSHOT.jar:6.2.0-SNAPSHOT]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
[na:1.8.0_101]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
[na:1.8.0_101]
at java.lang.Thread.run(Thread.java:745) [na:1.8.0_101]
{noformat}
> [Java Broker] Add experimental "pull" consumers to the broker
> -------------------------------------------------------------
>
> Key: QPID-7462
> URL: https://issues.apache.org/jira/browse/QPID-7462
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Attachments: QPID-7462.patch, QPID-7462_6.0.x.patch
>
>
> As per
> [this|http://qpid.2158936.n2.nabble.com/Qpid-broker-6-0-4-performance-issues-tp7652036.html]
> thread on the users list, our eventual goal is the elimination of the queue
> runners and moving to a model where the connection threads pull messages from
> the queues. In particular this allows multi-queue consumers to act in a
> "fair" manner between the multiple queues the consumer is associated with
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
