[ 
https://issues.apache.org/jira/browse/QPID-7486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15630890#comment-15630890
 ] 

Rob Godfrey commented on QPID-7486:
-----------------------------------


The change introduced by this JIRA made the system property work as a managed 
default in line with everything else in the broker.  The previous behaviour 
seems completely inconsistent (a system property that was treated differently 
to what amounts to an attribute setting on the object).  

Rather than restore the previous behaviour I think it makes more sense to add 
the ability to specify URLs of the form "classpath:..." that is to get the 
behaviour previously obtained by setting qpid.initialConfigurationLocation to 
"foo", you would now set it to "classpath:foo".  The "classpath:foo" form would 
also be available through the command line options, and similarly the system 
property can be set to any other arbitrary URL or file name. 

Since the previous behaviour (and the system property itself) was undocumented, 
I don't think changing this is going to cause a major issue for people.

> [Java Broker] Refactor broker startup code, remove BrokerOptions
> ----------------------------------------------------------------
>
>                 Key: QPID-7486
>                 URL: https://issues.apache.org/jira/browse/QPID-7486
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>             Fix For: qpid-java-6.2
>
>
> The code relating to the initial construction of the broker has evolved over 
> time leaving functionality spread across a number of different classes with 
> no clear division of responsibilities.
> Refactor so that Main in the broker module has responsibility for parsing of 
> command line arguments and conversion into SystemConfig attributes, as well 
> as providing the hooks into the desired logging provider.
> SystemLauncher (renamed from Broker) provides a thin layer of state 
> management (shutdown/startup) on top of the SystemConfig configured object.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to