Github user astitcher commented on a diff in the pull request:

    https://github.com/apache/qpid-proton/pull/88#discussion_r88113144
  
    --- Diff: proton-c/bindings/python/CMakeLists.txt ---
    @@ -122,3 +129,55 @@ install(TARGETS ${SWIG_MODULE_cproton_REAL_NAME}
             COMPONENT Python)
     
     set_directory_properties(PROPERTIES ADDITIONAL_MAKE_CLEAN_FILES 
"html;tutorial")
    +
    +#
    +# Set up the directory 'dist' for building the python native package
    +# source distribution for Pypi/pip
    +#
    +
    +set(py_dist_dir ${CMAKE_CURRENT_BINARY_DIR}/dist)
    +
    +configure_file(${CMAKE_CURRENT_SOURCE_DIR}/setup.py.in
    +               ${py_dist_dir}/setup.py
    +)
    +configure_file(${CMAKE_CURRENT_SOURCE_DIR}/README.rst.in
    +               ${py_dist_dir}/README.rst
    +)
    +
    +file(COPY ${py_dist_files} DESTINATION ${py_dist_dir})
    +
    +file(MAKE_DIRECTORY ${py_dist_dir}/proton)
    +file(COPY ${pysrc} DESTINATION ${py_dist_dir}/proton)
    +
    +#file(COPY ${py_dist_proton_c_files}
    --- End diff --
    
    Do you really want to add commented out lines?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to