[
https://issues.apache.org/jira/browse/PROTON-1352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15670604#comment-15670604
]
ASF GitHub Bot commented on PROTON-1352:
----------------------------------------
Github user gemmellr commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/89#discussion_r88247744
--- Diff:
proton-j/src/main/java/org/apache/qpid/proton/amqp/transport/ReceiverSettleMode.java
---
@@ -25,13 +25,32 @@
import org.apache.qpid.proton.amqp.UnsignedByte;
+import java.util.HashMap;
+import java.util.Map;
+
public enum ReceiverSettleMode
{
- FIRST, SECOND;
+ FIRST(0),
+ SECOND(1);
+
+ private UnsignedByte value;
+ private static Map<UnsignedByte, ReceiverSettleMode> map = new
HashMap<>();
+
+ private ReceiverSettleMode(int value) {
+ this.value = UnsignedByte.valueOf((byte)value);
+ }
- public UnsignedByte getValue()
- {
- return UnsignedByte.valueOf((byte)ordinal());
+ static {
+ for (ReceiverSettleMode mode: ReceiverSettleMode.values()) {
+ map.put(mode.value, mode);
+ }
}
+ public static ReceiverSettleMode valueOf(UnsignedByte value) {
+ return map.get(value);
--- End diff --
I think its worth throwing IAE if an out of bound value is provided, rather
than just returning null.
> Trivial casting from UnsignedByte to ReceiverSettleMode and SenderSettleMode
> ----------------------------------------------------------------------------
>
> Key: PROTON-1352
> URL: https://issues.apache.org/jira/browse/PROTON-1352
> Project: Qpid Proton
> Issue Type: Improvement
> Components: proton-j
> Affects Versions: 0.15.0
> Reporter: Paolo Patierno
> Priority: Minor
>
> Currently it's not trivial at application level execute casting from
> UnsignedByte to SenderSettleMode or ReceiverSettleMode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org
