----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53876/#review156299 -----------------------------------------------------------
Looks good to me. Can you add Chuck Rolke to the reviewer's list? He's found issues with how hostname is used w.r.t. Azure - might be a good idea to have him take a look at it (though I doubt it will affect things - better safe than sorry...) - Kenneth Giusti On Nov. 18, 2016, 1:58 p.m., Gordon Sim wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53876/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 1:58 p.m.) > > > Review request for qpid, Alan Conway, Justin Ross, Kenneth Giusti, and Robbie > Gemmell. > > > Repository: qpid-proton-git > > > Description > ------- > > Ulf's fix for https://issues.apache.org/jira/browse/PROTON-1355 allows you to > control the sni via the existing virtual host option. For cases where you > want the sni to be different from the hostname in the open frame, this patch > adds an explicit option. > > > Diffs > ----- > > proton-c/bindings/python/proton/reactor.py 3562aa9 > > Diff: https://reviews.apache.org/r/53876/diff/ > > > Testing > ------- > > > Thanks, > > Gordon Sim > >
