Github user lulf commented on a diff in the pull request:
https://github.com/apache/qpid-proton/pull/90#discussion_r88675979
--- Diff: proton-c/bindings/python/proton/reactor.py ---
@@ -565,7 +565,7 @@ def _connect(self, connection, reactor):
if not self.ssl_domain:
raise SSLUnavailable("amqps: SSL libraries not found")
self.ssl = SSL(transport, self.ssl_domain)
- self.ssl.peer_hostname = url.host
+ self.ssl.peer_hostname = self.virtual_host if
self.virtual_host != None else url.host
--- End diff --
Agreed. I chose to write it this way to be consistent with the rest of the
code which seems to explicitly check for None.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
