[ 
https://issues.apache.org/jira/browse/PROTON-1345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15677526#comment-15677526
 ] 

Ken Giusti commented on PROTON-1345:
------------------------------------

technically no - what needs to be done is have setup.py.in be configured by 
cmake to pass the proper sources in.

With PROTON-1330 this becomes almost trivial but not yet done.

> [python] Avoid hardcoding the list of C files to be compiled in setup.py
> ------------------------------------------------------------------------
>
>                 Key: PROTON-1345
>                 URL: https://issues.apache.org/jira/browse/PROTON-1345
>             Project: Qpid Proton
>          Issue Type: Bug
>          Components: python-binding
>    Affects Versions: 0.15.0
>            Reporter: Ken Giusti
>            Assignee: Ken Giusti
>             Fix For: 0.17.0
>
>
> Remove the hardcoded list of C source files in the setup.py file.  It's easy 
> to forget to update this list, and debugging the resulting tox build failure 
> is tricky.
> Instead have the setup.py discover all the necessary C source files using an 
> regex.  Add an explicit blacklist for those C source files that shouldn't be 
> built by the setup.py process (if there actually is any).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to