[ 
https://issues.apache.org/jira/browse/DISPATCH-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15684986#comment-15684986
 ] 

Alan Conway commented on DISPATCH-569:
--------------------------------------

Having all those empty cases is not great for readability, and bumping the 
version when it doesn't need to bump forces needless upgrades on deployments. 
How about we add a separate source file for detecting new events? We can have 
CMake compile it like a feature test and warn of changes without making 
dispatch needlessly un-buildable. If you like the idea I can do it.

> Dispatch does not compile due to new pn_event_type_t enum values.
> -----------------------------------------------------------------
>
>                 Key: DISPATCH-569
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-569
>             Project: Qpid Dispatch
>          Issue Type: Bug
>    Affects Versions: 0.7.0
>            Reporter: Alan Conway
>            Assignee: Alan Conway
>             Fix For: 0.8.0
>
>
> pn_event_handler has a switch that explicitly lists every enum value of 
> pn_event_type_t even though most of the cases do nothing. This fails to 
> compile against proton master, which has some new enum values.
> Replace the empty cases with a default: case



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to