[ https://issues.apache.org/jira/browse/QPID-7520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15695370#comment-15695370 ]
Keith Wall commented on QPID-7520: ---------------------------------- Change looks good. Typo would have had no functional defect, just a pointless extra evaluation (no short circuit). I had to re-read the Java spec to remind myself the behaviour http://docs.oracle.com/javase/specs/jls/se7/html/jls-15.html#jls-15.22.2 > [Java Broker] Improve writing to buffer in BooleanWriter from AMQP 1.0 codec > ------------------------------------------------------------------------------ > > Key: QPID-7520 > URL: https://issues.apache.org/jira/browse/QPID-7520 > Project: Qpid > Issue Type: Improvement > Components: Java Broker > Affects Versions: 0.32, qpid-java-6.0, qpid-java-6.0.1, qpid-java-6.0.2, > qpid-java-6.0.3, qpid-java-6.0.4, qpid-java-6.0.5, qpid-java-6.1 > Reporter: Alex Rudyy > Priority: Trivial > Fix For: qpid-java-6.2 > > > "if" condition in BooleanWriter#writeBuffer is evaluated using operand "&" > instead of "&&" which is not really required by the implementation logic. It > seems a "typo". -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org