[ 
https://issues.apache.org/jira/browse/DISPATCH-572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15705676#comment-15705676
 ] 

ASF GitHub Bot commented on DISPATCH-572:
-----------------------------------------

GitHub user ganeshmurthy opened a pull request:

    https://github.com/apache/qpid-dispatch/pull/118

    DISPATCH-572 - Add connection id to the Accepting connection log mess…

    …age so one can easily identify log messages on a specific connection

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ganeshmurthy/qpid-dispatch DISPATCH-572

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/qpid-dispatch/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit 3d07eaafd2f278295d2baca808da830034659147
Author: Ganesh Murthy <[email protected]>
Date:   2016-11-29T15:54:27Z

    DISPATCH-572 - Add connection id to the Accepting connection log message so 
one can easily identify log messages on a specific connection

----


> Adding log info with proton transport id and related remote IP/port
> -------------------------------------------------------------------
>
>                 Key: DISPATCH-572
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-572
>             Project: Qpid Dispatch
>          Issue Type: Improvement
>            Reporter: Paolo Patierno
>            Assignee: Ganesh Murthy
>             Fix For: 0.8.0
>
>
> Hi,
> enabling the Qpid Proton trace through PN_TRACE_FRM=1 when I start the Qpid 
> Dispatch Router, I need sometimes to know who is the remote peer is 
> exchanging traced messages.
> For example, considering these few lines of trace (running the Qpid Dispatch 
> Router) :
>  
> Accepted from 127.0.0.1:48192
> Accepted from 127.0.0.1:48190
> [0x7fbc44016390]:  <- SASL
> [0x7fbc44016390]:  -> SASL
> [0x7fbc44003b70]:  <- SASL
> [0x7fbc44003b70]:  -> SASL
> [0x7fbc44016390]:0 -> @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS, :PLAIN]]
> [0x7fbc44003b70]:0 -> @sasl-mechanisms(64) 
> [sasl-server-mechanisms=@PN_SYMBOL[:ANONYMOUS, :PLAIN]]
>  
> The router accepts two connections from remote clients (we see IP and port) 
> but then every message is related to an "identifier" (I guess it should be 
> the file descriptor related to the used socket).
> If I need to match these information with Wireshark (where I can see remote 
> port) I don't know if remote clients using remote port 48192 is related to 
> 0x7fbc44016390 or 0x7fbc44003b70.
> I think it could be a good information to add into the trace at least showing 
> the "identifier" after the accepted message, i.e. :
> Accepted from 127.0.0.1:48192 [0x7fbc44016390]
> It's also true, that messages related to something like [0x7fbc44016390] come 
> from Qpid Proton and messages like "Accepted ..." come from Qpid Dispatch 
> Router.
> Thanks,
> Paolo.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to