Github user ted-ross commented on a diff in the pull request:
https://github.com/apache/qpid-dispatch/pull/127#discussion_r93043324
--- Diff: src/router_node.c ---
@@ -947,6 +964,9 @@ static void CORE_delivery_update(void *context,
qdr_delivery_t *dlv, uint64_t di
pn_delivery_settle(pnd);
qdr_delivery_decref(dlv);
}
+
+ if (error)
--- End diff --
When you free the error record here, the pointer (now invalid) remains in
the delivery record. It could be referenced and possibly re-freed in the
future. I think the error record should be freed when the delivery record is
freed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
