[ 
https://issues.apache.org/jira/browse/DISPATCH-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15770077#comment-15770077
 ] 

ASF GitHub Bot commented on DISPATCH-209:
-----------------------------------------

Github user ted-ross commented on a diff in the pull request:

    https://github.com/apache/qpid-dispatch/pull/134#discussion_r93624286
  
    --- Diff: tests/system_tests_three_routers.py ---
    @@ -220,6 +225,71 @@ def run(self):
             Container(self).run()
      
      
    +class DynamicRequestResponseTest(MessagingHandler):
    +    def __init__(self, address1, address2):
    +        super(DynamicRequestResponseTest, self).__init__(prefetch=0)
    +        self.address1   = address1
    +        self.address2   = address2
    +        self.dest       = "closest.whatever"
    +        self.error      = None
    +        self.sender     = None
    +        self.server_receiver = None
    +        self.client_receiver = None
    +        self.n_expected = 10
    +        self.n_sent     = 0
    +        self.n_received = 0
    +        self.n_accepted = 0
    + 
    +    def timeout(self):
    +        self.error = "Timeout Expired %d messages received." % 
self.n_received
    +        self.conn1.close()
    +        self.conn2.close()
    + 
    +    def on_released(self, event):
    +        self.n_sent -= 1
    +        time.sleep(0.1)
    +
    +    def on_link_opened(self, event):
    +        if event.receiver:
    +            self.sender = event.container.create_sender(self.conn1, None)
    +
    +    def on_start(self, event):
    +        self.timer = event.reactor.schedule(5, Timeout(self))
    +        self.conn1 = event.container.connect(self.address1)
    +        self.conn2 = event.container.connect(self.address2)
    +        self.server_receiver = event.container.create_receiver(self.conn2, 
self.dest)
    +        self.client_receiver = event.container.create_receiver(self.conn2, 
None, dynamic=True)
    --- End diff --
    
    Both the client and server receivers are established on the same 
connection.  Is this what was intended?  I would think that one connection 
would be the client and the other the server.


> Three+ router test is needed in the system test suite.
> ------------------------------------------------------
>
>                 Key: DISPATCH-209
>                 URL: https://issues.apache.org/jira/browse/DISPATCH-209
>             Project: Qpid Dispatch
>          Issue Type: New Feature
>          Components: Tests
>            Reporter: Ted Ross
>            Assignee: michael goulish
>
> There have arisen some issues that would have been caught had there been a 
> three-router test in the regression suite.  This test should be added.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to