[ 
https://issues.apache.org/jira/browse/QPID-7607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15801501#comment-15801501
 ] 

Rob Godfrey commented on QPID-7607:
-----------------------------------

I don't think we need to worry about a receiving client not understanding the 
annotation... by definition a client should ignore an x-opt- annotation if they 
do not understand it.  I think it's more that if it is computationally 
expensive (and I doubt it is, because we are already doing a deep traversal of 
the objects in the map) we could choose not to add the annotation if we do not 
believe the client would act upon it.  I would suggest we simply always add the 
annotation if the message conforms with the JMS requirements.

> AMQP 1.0 conversion layer to use 'Map' x-opt-jms-msg-type annotation when 
> message is representable as a JMS Map Message and recipent known to be the 
> Qpid JMS Client 
> ---------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-7607
>                 URL: https://issues.apache.org/jira/browse/QPID-7607
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Priority: Minor
>             Fix For: qpid-java-7.0
>
>
> If the AMQP 1.0 converts a message for the Qpid JMS Client and the body is a 
> Map whose content conforms to the JMSMapMessage restrictions (string keys, 
> restricted domain of values etc), the conversion layer should set the 
> “x-opt-jms-msg-type”  annotation with a Map value so that the client, on 
> receipt, will produce a JMS Map Message for the application.
> For map messages converted from other protocols to AMQP 1.0, this will ensure 
> fidelity (currently the user receives an ObjectMessage - see test 
> {{org.apache.qpid.jms.provider.amqp.message.AmqpCodecTest#testCreateAmqpObjectMessageFromAmqpValueWithMap}}).
> For management responses, this will ensure that many management responses can 
> be handled simply.  
> If the map does not conform to the JMS restrictions or the client is not a 
> Qpid JMS Client, the annotation must not be applied.
> Q:  how should the broker know the client understands the 
> “x-opt-jms-msg-type” annotation? 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to