[ 
https://issues.apache.org/jira/browse/QPID-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839848#comment-15839848
 ] 

Rob Godfrey commented on QPID-7633:
-----------------------------------

On getLocalTransactionOpen, I agree that looks very dodgy.  In AMQP 0-x the 
value will only be 0 or 1, but I'm not sure the implementation the we have now 
is safe.  I think the implementations will need to define this properly (i.e. 
the calculation will need to be atomic, and the value may be > 1 for AMQP 1.0 )

> Remove SessionAdapter
> ---------------------
>
>                 Key: QPID-7633
>                 URL: https://issues.apache.org/jira/browse/QPID-7633
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>            Reporter: Keith Wall
>            Assignee: Lorenz Quack
>             Fix For: qpid-java-7.0
>
>         Attachments: 0001-QPID-7633-Java-Broker-Remove-SessionAdapter.patch, 
> QPID-7633.tar.bz2
>
>
> {{SessionAdapter}} is legacy code that predates the existing model.  It 
> should be removed, allowing for better code reuse between session 
> implementations and better unit/smoke tests.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to