[
https://issues.apache.org/jira/browse/QPID-7601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15840058#comment-15840058
]
Alex Rudyy commented on QPID-7601:
----------------------------------
I reviewed the changes made in commit [https://svn.apache.org/r1776351] and
here are my comments
* {{org.apache.qpid.server.model.validation.AttributeAnnotationValidator}}
Parameter '{{allowAbstractManagedTypes}}' is unused in method
{{#processAttributes}}.
Should it be passed through into {{checkMethodReturnType}} and used for type
validation?
*
{{org.apache.qpid.server.model.AttributeValueConverter.ObjectMethodValueMethod}}
and
{{org.apache.qpid.server.model.AttributeValueConverter.StaticMethodValueMethod}}
{{IllegalArgumentException}} is thrown from {{#getValue(X object)}} on
occurance of {{IllegalAccessException}} or {{InvocationTargetException}}
I think that {{InvocationTargetException#cause}} should be chained instead of
{{InvocationTargetException}}.
> [Java Broker] Allow annotations to define ManagedAttributeValueTypes as
> abstract, some methods as derived
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-7601
> URL: https://issues.apache.org/jira/browse/QPID-7601
> Project: Qpid
> Issue Type: Improvement
> Components: Java Broker
> Reporter: Rob Godfrey
> Assignee: Rob Godfrey
> Fix For: qpid-java-7.0
>
>
> ManagedAttributeValueTypes may form a type hierarchy, however there is no way
> for a value to be resolved to a particular instance class.
> A type can be marked as abstract meaning that it cannot itself be
> instantiated from an input value (i.e. it cannot be used as a managed
> attribute, or the input to an operation). An abstract type can be used as an
> output value (e.g. as a return value from an operation, or as a derived
> attribute).
> Further we should allow ManagedAttributeTypes to themselves have derived
> attributes. These attributes should be returned from query methods, but not
> persisted, and values for these attributes should be ignored when present in
> input data.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
