[
https://issues.apache.org/jira/browse/QPID-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15851330#comment-15851330
]
Rob Godfrey commented on QPID-7658:
-----------------------------------
Surely the link registry state will need to be persisted, and thus replicated
when using HA virtual hosts, which precludes the sharing of a link registry
between different virtual hosts on the same broker (unless you propose there is
a single shared link registry across all Java Brokers in existence). As such I
fail to se the utility in supplying the localContainerId in to these methods.
I think by definition a link registry is specific to the (local) container.
> [Java Broker] Improve LinkRegistry
> ----------------------------------
>
> Key: QPID-7658
> URL: https://issues.apache.org/jira/browse/QPID-7658
> Project: Qpid
> Issue Type: Task
> Components: Java Broker
> Reporter: Lorenz Quack
> Fix For: qpid-java-7.0
>
>
> Currently the AbstractVirtualHost has a Map<remoteContainerId, LinkRegistry>.
> The handling of the remoteContainerId should also be encapsulated in the
> LinkRegistry giving each VH only a single LinkRegistry.
> Furthermore the following change to the LinkRegistry is proposed:
> * LinkRegistry.putSendingLinkIfAbsent(String localContainerId, String
> remoteContrainerId, String linkName, Source source, Target target) ->
> Pair<Source, Target>
> * LinkRegistry.putReceivingLinkIfAbsent(String localContainerId, String
> remoteContrainerId, String linkName, Source source, Target target) ->
> Pair<Source, Target>
> * LinkRegistry.getSendvingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.getReceivingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.removeSendingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> * LinkRegistry.removeReceivingLink(String localContainerId, String
> remoteContrainerId, String linkName) -> Pair<Source, Target>
> The implementation of which must be thread-safe because the LinkRegistry will
> be accessed on multiple threads concurrently.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
