Github user gemmellr commented on the issue:
https://github.com/apache/qpid-proton-j/pull/2
I've raised #3 with some alternative changes, which are essentially just a
subset of yours with a different test. One of the changes here would corrupt
the linkPrev/next entries chain, which is essentially part of the problem the
changes are really trying to adress, while some others would only make a
difference if the entries were already corrupt. The main change required to
address the retention issue is the nulling of old refs while removing the
delivery from the chain, and the related change to ensure the link free'ing
process then doesn't give up early when it iterates the remaining deliveries.
If you can give #3 a try out that would be great.
Some pointers for future PRs (which I shall add to the site/repo's at some
point soon so folks can actually see it in advance, or we can reference it
later):
- If you raise the PR with the JIRA key in the title, a bot will raise a
note against the JIRA for open/close and also relay future comments to the JIRA.
- Similarly if you could include the key in the commit log message, that
way a bot records it on the JIRA upon eventual commit.
- Your PR had some cruft commits/changes from doing merges. In general PRs
should be a single commit rebased to sit on the current master without any
merge commits. Multiple commits can be useful if its a many-layered change and
the steps help evaluate it however.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
